[Debezium] Better support around JSON arrays #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tang8330
changed the title
danafallon
reviewed
Dec 12, 2024
lib/debezium/schema.go
Outdated
| type Field struct { | ||
| Type FieldType `json:"type"` | ||
| Optional bool `json:"optional"` | ||
| Default any `json:"default"` | ||
| FieldName string `json:"field"` | ||
| DebeziumType SupportedDebeziumType `json:"name"` | ||
| Parameters map[string]any `json:"parameters"` | ||
| // [Items] is only populated if the literal type is an array. | ||
| Items Item `json:"items"` |
There was a problem hiding this comment.
Items being plural is a little confusing here, maybe we could call this ItemsMetadata?
danafallon
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debezium will emit
{ "type": "array", "items": { "type": "string", "optional": true, "name": "io.debezium.data.Json", "version": 1 }, "optional": true, "field": "attributes" }As the field object if the value contains an array of JSON objects. We were previously not doing anything with this information.
As such, we were mainly returning an array of JSON strings (which is what Debezium emits). This PR adds the ability for us to check the
items.nameand if it's JSON, we'll add an additional step to parse the JSON string into an object.