[Typing] Simplify Ext Parse #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathan-artie
reviewed
Sep 9, 2024
| // Now check TIME formats | ||
| for _, supportedTimeFormat := range SupportedTimeFormatsLegacy { | ||
| ts, exactMatch, err := ParseTimeExactMatchLegacy(supportedTimeFormat, dtString) | ||
| if err == nil && exactMatch { | ||
| slog.Error("Unexpected call to SupportedTimeFormatsLegacy", |
There was a problem hiding this comment.
Should we remove this entire loop? Looks like we don't actually expect to match any time formats, but with this change we'll still support matching time formats.
There was a problem hiding this comment.
We should keep it because we'll need it for the inference work later (When we encounter a TIME column later and we have a string value, we should try to parse the string value as TIME)
nathan-artie
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging this as there were no logs from #895