-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use container images in lambda #2674
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardobridge
force-pushed
the
art-1770-lambda-docker-container-images
branch
from
April 30, 2024 09:43
e77ba9f
to
6615068
Compare
hassy
reviewed
May 1, 2024
hassy
reviewed
May 1, 2024
hassy
reviewed
May 1, 2024
hassy
reviewed
May 1, 2024
hassy
reviewed
May 1, 2024
This was referenced May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reviewing commit by commit is recommended.
Adds
--container
flag that allows a Lambda test to run using Lambda Container Images. This solves a lot of the current limitations of Lambda:Compatible with Playwright (experimental, so there may be some performance limitations)-> To be addressed laterNotes:
To-do:
Add compatibility with Playwright Engine-> TBA laterDeprecation notice for regular Lambda support