Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use container images in lambda #2674

Merged
merged 13 commits into from
May 1, 2024

Conversation

bernardobridge
Copy link
Contributor

@bernardobridge bernardobridge commented Apr 25, 2024

Description

Reviewing commit by commit is recommended.

Adds --container flag that allows a Lambda test to run using Lambda Container Images. This solves a lot of the current limitations of Lambda:

  • No more bundle size limit issues
  • Can reuse same Lambda function, making startup time go down to a few seconds
  • Publish Metrics will work once again
  • Third-party dependencies (npm modules) will now work
  • Compatible with Playwright (experimental, so there may be some performance limitations) -> To be addressed later

Notes:

  • Change is backwards compatible, and current tests will not be affected (they will use zip-file Lambda by default).
  • The main drawback is that Lambda does not support Public ECR images. This means users will need to pull and host our image in their own ECR Private repo, and update it with Artillery updates. We will provide some installation scripts/instructions for users.

To-do:

  • Refactor Lambda to make it easier to keep backwards compatibility (c894486, 2b39f09)
  • Implement Lambda using container images opted-in (66498cf)
  • Reuse same Docker image for Lambda and Fargate (43d954a, f860db5, 04015c3)
  • Reuse same Lambda function (WIP - need to figure out mechanism to determine version)
  • Add compatibility with Playwright Engine -> TBA later
  • Deprecation notice for regular Lambda support
  • Improve console messages when packaging

@bernardobridge bernardobridge force-pushed the art-1770-lambda-docker-container-images branch from e77ba9f to 6615068 Compare April 30, 2024 09:43
@bernardobridge bernardobridge marked this pull request as ready for review April 30, 2024 15:29
@bernardobridge bernardobridge merged commit b9d895b into main May 1, 2024
21 checks passed
@bernardobridge bernardobridge deleted the art-1770-lambda-docker-container-images branch May 1, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants