Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slack): make slack work with distributed tests #2754

Merged
merged 3 commits into from
May 27, 2024
Merged

Conversation

InesNi
Copy link
Contributor

@InesNi InesNi commented May 15, 2024

Description

1. Enabling Slack Plugin for Fargate runs:

  • Manually instantiating the plugin in run-cluster.js similar to ensure plugin. ( plugins are not automatically loaded in main thread for Fargate runs)
  • Disabling slack in cloud workers to avoid sending duplicate notifications.
  • Setting the global.artillery.cloudEnabled variable in run-fargate. slack uses this variable to check if a run URL needs to be included in the notification. It is set in run.js when cloud is enabled but was missing in run-fargate
  • Adding slack to both official plugin lists

2. Enabling Slack Plugin for Lambda runs

  • Setting the WORKER_ID to process.env
  • Works with containerized Lambda (tested manually) and should work with .zip file version but can't test easily as local changes from other unreleased packages aren't reflected

3. A few additional smaller changes have been added:

  • As a tweak to duration - seconds are ceiled rather than floored so that duration in notification doesn't always appear to be 1 second less that the duration set in the test script.
  • A few more debug messages were added to make debugging easier

Testing

  • Manually ran multiple tests to ensure it works as expected:
    • with varied arrivalRate, duration and container count
    • with and without ensure plugin as well as with and without failed checks.
    • with and without errors
    • for tests that are recorded to Artillery Cloud and ones that are not.

Pre-merge checklist

  • Does this require an update to the docs?
  • Does this require a changelog entry?

@InesNi InesNi marked this pull request as ready for review May 16, 2024 10:40
@InesNi InesNi force-pushed the slack-fargate-fix branch from 548cab6 to 70cc0b2 Compare May 16, 2024 10:44
@InesNi InesNi changed the title fix(slack): make slack work with fargate fix(slack): make slack work with distributed tests May 16, 2024
@hassy hassy merged commit 8ae17dd into main May 27, 2024
23 checks passed
@hassy hassy deleted the slack-fargate-fix branch May 27, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants