Advanced search layout #173
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsinghal
requested changes
Oct 25, 2021
muildrik
commented
Nov 3, 2021
There was a problem hiding this comment.
Added a few files and moving on to MET--will have a branch ready for that soon. What works best for you guys to surface new fields? Also, advanced search by date range requires a field entrydate_ms; I've written a script to convert dates in entrydate fields to milliseconds for that function to work. Would you want to run that locally or do you have another way?
rsinghal
reviewed
Nov 5, 2021
muildrik
commented
Nov 5, 2021
There was a problem hiding this comment.
- Removed flags and added other files to .gitignore.
- views_utils.py has MET dictionary and is therefore stupidly long;
- search.html has new HTML markup for advanced search, nothing special there.
- rewritten a few functions in giza.js, but functionality exactly the same (basically only changed a few function calls to modern standards)
- search_tags.py: two functions that are part of MET and don't do anything yet--may well disappear in future commits
- views.py: rewritten functions, added functions to convert entrydate text string to milliseconds for querying; added small subroutine for querying ES to look for milliseconds if request is entrydate field
This was only a backup file I used as I was modifying searchresults.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.