Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@alloy => Add cache section to docs #14

Merged
merged 4 commits into from
Jul 21, 2017
Merged

Conversation

kanaabe
Copy link
Contributor

@kanaabe kanaabe commented Jun 6, 2017

We found that the handoff still happened for some people, even after apple-site-association.json was uploaded to Sailthru. The problem turned out to be that this file gets cached when a user first installs the app. So, to invalidate the cache and update to the latest apple-site-association.json, you have to reinstall the app, update the app if there is an update, or turn off UL once and turn it on again. This isn't ideal for updates to routes like /venice-biennale where we would need to make constant updates.

Pushing Sailthru to support multiple link domains per email won't solve the entire problem since people with old caches will still get redirected via other iOS apps. Unless we can find a way to bust that cache for all users magically, I think getting these features into a nested route might be a good solution. What do you think?

@alloy
Copy link
Contributor

alloy commented Jun 7, 2017

Pretty sure it periodically updates the cache in between installs/updates, alas the rules aren’t documented. iirc, black in the early days, if you wanted to debug changes you had to change the date and restart the phone.

Nonetheless, I am sooooo in favour of getting rid of vanity URLs, I’ve been advocating to get rid of them since forever. Are you sure that nobody would overrule and create a vanity URL after all?

README.md Outdated

## Caching

Apple caches the apple-app-site-association file on app install. This means any updates to the `apple-app-site-association` file will only affect users who have recently installed the app, updated the app, or turned Universal Linking [off (and on again)](https://stackoverflow.com/questions/32729489/how-can-i-reset-ios-9-universal-linking-settings). More details about how Apple caches this file can be found on this [Stack Overflow answer](https://stackoverflow.com/a/41305871).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It definitely updates periodically in between installs/updates, I think it’s daily but in true Apple fashion it’s not documented. The main issue remains, of course, it’s not necessarily updated when we would like it to.

Copy link
Contributor Author

@kanaabe kanaabe Jun 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you know this? Because if it is daily, that makes me feel like it's ok to have vanity urls. I see why people want them.

Also, not sure what you mean by:

Are you sure that nobody would overrule and create a vanity URL after all?

edit: nevermind, I know what you mean.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you know this?

Eh, it was a StackOverflow type of thingie I found somewhere that said that to re-cache the manifest you had to change the date of the device and reboot. Alas I can’t easily find that answer again right now.

Come to think of it, that may mean it’s not daily, but after reboot and at most once a day 🤔

Because if it is daily, that makes me feel like it's ok to have vanity urls.

Seeing as I can’t easily find that old answer right now, we may have to verify this ourselves first 😕

I see why people want them.

Yeah totally, me too. My problem with them is larger in the context of the app (makes it harder to route to a view).

@kanaabe kanaabe merged commit feb04c7 into artsy:master Jul 21, 2017
@artsyit
Copy link
Contributor

artsyit commented Nov 2, 2021

🚀 PR was released in v1.1.0 🚀

@artsyit artsyit added the released This issue/pull request has been released. label Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants