@alloy => Update hash to multiple of 3 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
………… for reals??? Why do they require that? And are you sure this always worked that way? I find it hard to believe we never verified things to work before :/ |
|
@alloy I'm surprised we didn't catch it earlier either. I'm not sure of the timeline but they said the issue is on their backlog. 🤷♀️ |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, this PR updates the hash to use chars in a multiple of 3.
Second, we discovered something interesting the other day -- this whole time we thought uploading the json file to ST meant that new rules would be applied, right? It turns out the first upload works but any other changes afterwards need to be changed by Sailthru's internal team. 💀