Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent collection pages from opening in the app #23

Merged
merged 4 commits into from
Jan 15, 2019

Conversation

xtina-starr
Copy link
Contributor

Addresses: https://artsyproduct.atlassian.net/browse/GROW-996

This PR adds the collection paths (/collection/:id) to the apple-app-site-association.json to be blacklisted so that they won't show up in the iOS app. It seems pretty straightforward but I'm wondering how do I go about verifying this. That's why I've marked this as WIP because it's not yet be verified.

@alloy
Copy link
Contributor

alloy commented Dec 10, 2018

To make sure these links get excluded when sent through Sailthru as well you should run this script: https://github.com/artsy/artsy-eigen-web-association/blob/master/add-sailthru-paths.js

$ node add-sailthru-paths.js

Once this is merged and updated in Force, artsy-wwwify, and uploaded to Sailthru, you should be able to verify this in the app (you may need to reboot your device).

@alloy
Copy link
Contributor

alloy commented Dec 10, 2018

Can you also add these steps I listed to the README?

@xtina-starr
Copy link
Contributor Author

So instruction for running the script are actually in the README under Change config file. It's handled in the yarn build command. I did fix one minor error in the script comments though.

@alloy
Copy link
Contributor

alloy commented Dec 12, 2018

Ping me when/if this needs another review.

@xtina-starr
Copy link
Contributor Author

Had a sync up with product and it seems we want to move forward with this approach so another review would be awesome.

@alloy
Copy link
Contributor

alloy commented Jan 9, 2019

Sorry, I missed your question. Is this still the case?

@xtina-starr xtina-starr changed the title [WIP] prevent collection pages from opening in the app prevent collection pages from opening in the app Jan 14, 2019
@xtina-starr xtina-starr force-pushed the add-collections-blacklist branch from b801a56 to bc87a9c Compare January 15, 2019 16:29
@xtina-starr xtina-starr merged commit 2ca2195 into master Jan 15, 2019
@icirellik icirellik deleted the add-collections-blacklist branch December 7, 2020 21:46
@artsyit
Copy link
Contributor

artsyit commented Nov 2, 2021

🚀 PR was released in v1.1.0 🚀

@artsyit artsyit added the released This issue/pull request has been released. label Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jira Synced released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants