-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prevent collection pages from opening in the app #23
Conversation
To make sure these links get excluded when sent through Sailthru as well you should run this script: https://github.com/artsy/artsy-eigen-web-association/blob/master/add-sailthru-paths.js
Once this is merged and updated in Force, artsy-wwwify, and uploaded to Sailthru, you should be able to verify this in the app (you may need to reboot your device). |
Can you also add these steps I listed to the README? |
So instruction for running the script are actually in the README under Change config file. It's handled in the |
Ping me when/if this needs another review. |
Had a sync up with product and it seems we want to move forward with this approach so another review would be awesome. |
Sorry, I missed your question. Is this still the case? |
b801a56
to
bc87a9c
Compare
🚀 PR was released in |
Addresses: https://artsyproduct.atlassian.net/browse/GROW-996
This PR adds the collection paths (
/collection/:id
) to theapple-app-site-association.json
to be blacklisted so that they won't show up in the iOS app. It seems pretty straightforward but I'm wondering how do I go about verifying this. That's why I've marked this as WIP because it's not yet be verified.