Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent facebook auth to open inside the app #24

Merged
merged 1 commit into from
Jan 22, 2019
Merged

Prevent facebook auth to open inside the app #24

merged 1 commit into from
Jan 22, 2019

Conversation

l2succes
Copy link
Contributor

Related: https://artsyproduct.atlassian.net/browse/PURCHASE-805

This should prevent facebook auth redirect URL from opening the Artsy app and keep the flow in mobile web

ashfurrow
ashfurrow approved these changes Jan 22, 2019
View reviewed changes
Copy link
Contributor

@ashfurrow ashfurrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I didn't realize this was in its own repo haha. Good work!

@ashfurrow ashfurrow merged commit b037a0f into master Jan 22, 2019
@ashfurrow ashfurrow deleted the facebook-auth branch January 22, 2019 19:18
@l2succes l2succes mentioned this pull request Jan 22, 2019
Merged
@artsyit
Copy link
Contributor

artsyit commented Nov 2, 2021

🚀 PR was released in v1.1.0 🚀

@artsyit artsyit added the released This issue/pull request has been released. label Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashfurrow ashfurrow ashfurrow approved these changes

Assignees

@ashfurrow ashfurrow

Labels
Jira Synced released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@l2succes @artsyit @ashfurrow