Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@alloy => Restricts all articles from going to the app #5

Merged
merged 1 commit into from
Mar 7, 2017

Conversation

kanaabe
Copy link
Contributor

@kanaabe kanaabe commented Mar 7, 2017

Was asked to restrict all articles opened from links on mobile from opening in the app.

cc @owendodd

@alloy
Copy link
Contributor

alloy commented Mar 7, 2017

The change looks good, I'm just wondering why this is and if/where previous discussion about this took place?

@kanaabe
Copy link
Contributor Author

kanaabe commented Mar 7, 2017

Good question! I wasn't at today's Content meeting but it was discussed then, and I believe Carter brought it up. That's as much as I know!

I think it has to do with speed (currently have to wait for the app to load, and then open a web page as opposed to getting to the content asap), but don't quote me on that.

@owendodd could you provide more context?

@alloy
Copy link
Contributor

alloy commented Mar 7, 2017

Yeah that makes sense and it's not like the app offers much over a browser when it comes to articles, except showing linked artists/artworks in their native Eigen views.

@owendodd
Copy link

owendodd commented Mar 7, 2017

Yeah Kana highlighted most of the important points.

It's mostly a speed issue. Editorial content definitely feels slower when opening in app vs browser. Increasing engagement there feels like a big win, especially from email.

It's something we have talked about a few times before and just never gotten around to doing.

@alloy
Copy link
Contributor

alloy commented Mar 7, 2017

Thanks for the info 🙏🏽

@alloy alloy merged commit 1e410f9 into master Mar 7, 2017
@alloy alloy deleted the all-articles branch March 7, 2017 23:14
@kanaabe
Copy link
Contributor Author

kanaabe commented Mar 24, 2017

@alloy is there any reason this wouldn't work for some situations? I'm trying to replicate what Carter reported -- he clicked from a Hacker News post to an Artsy link and it opened up the app. I've tried with different browsers but it doesn't bring me to the app.

@alloy
Copy link
Contributor

alloy commented Mar 24, 2017

@kanaabe Hrmm, not from the top of my head. What was the URL?

@kanaabe
Copy link
Contributor Author

kanaabe commented Mar 24, 2017

@alloy
Copy link
Contributor

alloy commented Mar 24, 2017

Yup, opens with the app for me too. How are you trying to get reproduce this? (It is only triggered if you tap a link, not if you enter it in e.g. a browser’s address bar.)

The reason is that it appears these changes were not deployed to Force and the www-ify app, looking at www.artsy.net and artsy.net shows that neither include the exclusion patterns: https://limitless-sierra-4673.herokuapp.com. And indeed the signed file was not updated in this PR, so I should have realised then that it wasn’t going to be deployed, my bad.

Let me know if the instructions in the README work for you and afterwards be sure to update this dependency in the apps.

@kanaabe
Copy link
Contributor Author

kanaabe commented Mar 24, 2017

Ah interesting -- thanks for the explanation. My bad for not reading the docs beforehand. As for reproducing, I'm tapping the link normally so that is still a mystery.

@artsyit
Copy link
Contributor

artsyit commented Nov 2, 2021

🚀 PR was released in v1.1.0 🚀

@artsyit artsyit added the released This issue/pull request has been released. label Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants