feat: Artsy Open #156
Merged
feat: Artsy Open #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olerichter00
force-pushed
the
olerichter00/artsy-open
branch
2 times, most recently
from
c6437a8
to
1580776
Compare
dblandin
approved these changes
May 25, 2021
src/lib/open/data/config.json
Outdated
| }, | ||
| "environments": { | ||
| "local": "http://localhost:3000", | ||
| "production": "https://artsy.net", |
There was a problem hiding this comment.
Should we update this from https://artsy.net to https://www.artsy.net to avoid the redirect?
|
|
||
| const templatePath = removeTrailingSlash(pages[dashify(input)] || input) | ||
|
|
||
| const path = template(templatePath, variables) |
src/lib/open/index.ts
Outdated
| Ios.openAsync({ uri }) | ||
| break | ||
| case "web": | ||
| open(uri) |
There was a problem hiding this comment.
oclif has a built in utility for opening URLs in the browser: https://github.com/oclif/cli-ux#cliopen
Might be worth using so we can drop a dependency?
anandaroop
approved these changes
May 25, 2021
olerichter00
force-pushed
the
olerichter00/artsy-open
branch
3 times, most recently
from
1713817
to
eb71f40
Compare
olerichter00
force-pushed
the
olerichter00/artsy-open
branch
2 times, most recently
from
7ed660f
to
a0c05ac
Compare
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Open Artsy pages with the iOS, Android or the browser which allows to fastly navigate to any page in our app.
Pages can be opened via a URL, a path, or an alias (e.g.
artsy open artistwill open the artist page using an artist id from the config file that can be customized).Examples:
With an alias:
opens https://artsy.net/artwork/banksy-love-rat-signed-16 on iOS
With a path:
opens https://artsy.net/artwork/banksy-love-rat-signed-16 on iOS
With a full URL:
opens https://staging.artsy.net/artwork/banksy-love-rat-signed-16 on iOS
With flags:
opens https://localhost:3000/artwork/banksy-love-rat-signed-16 on Android
With custom variables:
opens https://artsy.net/artist/andy-warhol on Android