feat: improve recent podcast summary #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepopowitz
commented
Jul 12, 2021
| return "" | ||
| } | ||
|
|
||
| return urlString.replace(".mp3", "") |
There was a problem hiding this comment.
buzzsprout's webpage for the episode is the same URL as the mp3 itself, without .mp3.
| @@ -81,7 +81,7 @@ describe("scheduled:recently-published", () => { | |||
| text: { | |||
| type: "mrkdwn", | |||
| text: | |||
| "> <p>Steve Hicks and Justin Bennett talk about empathy in workplace culture, how to build trust and safety, and the importance of providing space for people.</p>", | |||
There was a problem hiding this comment.
Oops! I didn't notice this until after pointing at buzzsprout for this command, but this block wouldn't have displayed very nicely in slack.
dblandin
approved these changes
Jul 15, 2021
| const markdown = turndownService.turndown( | ||
| `<blockquote>${content}</blockquote>` | ||
| ) | ||
| return markdown |
| @@ -101,14 +105,14 @@ export default class ScheduledRecentlyPublished extends Command { | |||
| type: "section", | |||
| text: { | |||
| type: "mrkdwn", | |||
| text: `${title} | <https://podcasts.apple.com/us/podcast/artsy-engineering-radio/id1545870104|Apple Podcasts> | <https://podcasts.google.com/feed/aHR0cHM6Ly9hcnRzeS5naXRodWIuaW8vcG9kY2FzdC54bWw|Google Podcasts> | <https://open.spotify.com/show/0gJYxpqN6P11dbjNw8VT2a?si=L4TWDrQETwuVO6JR1SOZTQ|Spotify>`, | |||
| text: `<${webURL}|${title}>`, | |||
|
🚀 PR was released in |
1 similar comment
|
🚀 PR was released in |
|
🚀 PR was released in |
3 similar comments
|
🚀 PR was released in |
|
🚀 PR was released in |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up a few things for the
scheduled:recently-publishedtask, for the weekly update that gets posted to slack.What the updated blocks look like
(The gray "Artsy Engineering" next to "Jul 8, 2021" is the author of the episode...I think we've not been filling it in on buzzsprout when we upload episodes, and it defaults to our account name.)