Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the API playground work against Swagger 2.0 implementation in Gravity. #139

Merged
merged 3 commits into from
Oct 26, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 64 additions & 16 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -1,16 +1,32 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2017-10-11 13:16:21 -0400 using RuboCop version 0.50.0.
# on 2018-10-25 13:54:35 -0400 using RuboCop version 0.59.2.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to call out that this file looks like it's meant to get smaller but seems in fact to be getting bigger. If we care about rubocop linting ought we consider taking a moment to clean this up?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but in a separate PR. My workflow for this is rubocop -a ; rubocop --auto-gen-config.

# Offense count: 5
# Cop supports --auto-correct.
Layout/ClosingHeredocIndentation:
Exclude:
- 'spec/helpers/markdown_helper_spec.rb'

# Offense count: 11
# Cop supports --auto-correct.
Layout/EmptyLineAfterGuardClause:
Exclude:
- 'app/controllers/application_controller.rb'
- 'app/controllers/client_applications_controller.rb'
- 'app/controllers/pages_controller.rb'
- 'app/controllers/start_controller.rb'
- 'app/helpers/open_redirect_helper.rb'

# Offense count: 1
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyleAlignWith, SupportedStylesAlignWith, AutoCorrect.
# Configuration parameters: EnforcedStyleAlignWith, AutoCorrect, Severity.
# SupportedStylesAlignWith: keyword, variable, start_of_line
Lint/EndAlignment:
Layout/EndAlignment:
Exclude:
- 'app/controllers/application_controller.rb'

Expand All @@ -19,20 +35,13 @@ Lint/HandleExceptions:
Exclude:
- 'app/controllers/welcome_controller.rb'

# Offense count: 5
Lint/RescueWithoutErrorClass:
Exclude:
- 'app/controllers/client_applications_controller.rb'
- 'app/controllers/pages_controller.rb'
- 'app/controllers/start_controller.rb'
- 'app/controllers/welcome_controller.rb'

# Offense count: 8
Metrics/AbcSize:
Max: 43

# Offense count: 24
# Offense count: 25
# Configuration parameters: CountComments, ExcludedMethods.
# ExcludedMethods: refine
Metrics/BlockLength:
Max: 170

Expand All @@ -41,7 +50,7 @@ Metrics/CyclomaticComplexity:
Max: 13

# Offense count: 4
# Configuration parameters: CountComments.
# Configuration parameters: CountComments, ExcludedMethods.
Metrics/MethodLength:
Max: 33

Expand All @@ -51,33 +60,72 @@ Metrics/PerceivedComplexity:

# Offense count: 6
# Configuration parameters: Blacklist.
# Blacklist: END, (?-mix:EO[A-Z]{1})
# Blacklist: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
Naming/HeredocDelimiterNaming:
Exclude:
- 'app/controllers/pages_controller.rb'
- 'spec/helpers/markdown_helper_spec.rb'

# Offense count: 1
# Configuration parameters: EnforcedStyleForLeadingUnderscores.
# SupportedStylesForLeadingUnderscores: disallowed, required, optional
Naming/MemoizedInstanceVariableName:
Exclude:
- 'app/controllers/application_controller.rb'

# Offense count: 2
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: braces, no_braces, context_dependent
Style/BracesAroundHashParameters:
Exclude:
- 'spec/features/start_spec.rb'
- 'spec/requests/start_spec.rb'

# Offense count: 5
# Cop supports --auto-correct.
Style/ExpandPathArguments:
Exclude:
- 'Rakefile'
- 'config/application.rb'
- 'config/boot.rb'
- 'config/environment.rb'
- 'spec/spec_helper.rb'

# Offense count: 1
# Configuration parameters: MinBodyLength.
Style/GuardClause:
Exclude:
- 'app/controllers/pages_controller.rb'

# Offense count: 1
Style/MixinUsage:
Exclude:
- 'spec/support/warden.rb'

# Offense count: 4
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes.
# Configuration parameters: EnforcedStyle, AllowInnerSlashes.
# SupportedStyles: slashes, percent_r, mixed
Style/RegexpLiteral:
Exclude:
- 'Guardfile'
- 'app/controllers/pages_controller.rb'
- 'spec/features/docs_spec.rb'

# Offense count: 5
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: implicit, explicit
Style/RescueStandardError:
Exclude:
- 'app/controllers/client_applications_controller.rb'
- 'app/controllers/pages_controller.rb'
- 'app/controllers/start_controller.rb'
- 'app/controllers/welcome_controller.rb'

# Offense count: 80
# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
# URISchemes: http, https
Metrics/LineLength:
Max: 143
13 changes: 13 additions & 0 deletions DEV.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
## Dev Stuff

### Upgrading Swagger-UI

Get the latest version of [swagger-ui](https://github.com/swagger-api/swagger-ui) from the [swagger-ui-dist distribution channel](https://github.com/swagger-api/swagger-ui/blob/master/docs/usage/installation.md).

```
npm install swagger-ui-dist
```

Replace everything in [vendor/assets/swagger-ui-dist](vendor/assets/swagger-ui-dist) with the files from that distribution.

Make sure it works locally against staging, see [CONTRIBUTING](CONTRIBUTING.md) for how to setup Doppler locally.
Loading