This repository has been archived by the owner on Mar 17, 2021. It is now read-only.
Collapse existing duplicates to shorten message #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/artsy/dupe-report/njxd0ea3u |
zephraph
commented
Jan 5, 2020
| @@ -103,6 +114,6 @@ export const formatReport = (report: string, diff: string, change: number, assig | |||
| "\n\n" + | |||
| "---" + | |||
| "\n\n" + | |||
| formatBody(bodyData as BodyData[]) | |||
| collapsible("Existing duplicates", formatBody(bodyData as BodyData[])) | |||
There was a problem hiding this comment.
This is the only actual change.
|
Sweet. |
|
🚀 PR was released in v0.35.1 🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This collapses the existing dependencies down into a details view so it doesn't push out the message so far. Most of the time folks don't care about that info, so there's no reason to have it taking up so much space.
The other changes are just from prettier.