Move echo to S3 🎉 #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashfurrow
reviewed
Oct 9, 2020
damassi
reviewed
Oct 17, 2020
|
This is ready to go. I'll do the horizon changes now, and once this is merged I'll make the |
ashfurrow
approved these changes
Oct 20, 2020
| * __Github:__ [https://github.com/artsy/echo/](https://github.com/artsy/echo/) | ||
| * __CI:__ [Semaphore](https://semaphoreci.com/artsy-it/echo/); merged PRs to artsy/echo#master are automatically deployed to staging; production is manually deployed from Semaphore | ||
| * __Point People:__ [@ashfurrow](https://github.com/ashfurrow) | ||
| * __Point People:__ [@ashfurrow](https://github.com/ashfurrow), [@pvinis](https://github.com/pvinis) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up:
productionbranch frommaster.masterinstead ofs3andproductioninstead ofs3-productionfor all stages and deploy strategies.No. Even if we do, it's easy enough to add a dummy flag.