This repository has been archived by the owner on Jan 4, 2023. It is now read-only.
Fixes CardFlight integration #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay..... Circle CI needs upgrading too. I've opened a ticket to track that and have verified that the tests pass locally. |
ashfurrow
added a commit
that referenced
this pull request
Oct 30, 2018
Fixes CardFlight integration
ashfurrow
added a commit
that referenced
this pull request
Oct 30, 2018
Fixes CardFlight integration
ashfurrow
added a commit
that referenced
this pull request
Oct 30, 2018
Fixes CardFlight integration
ashfurrow
added a commit
that referenced
this pull request
Oct 30, 2018
Fixes CardFlight integration
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unblocks work on our Q4 Kiosk Updates.
This reverts #687. See this Jira ticket for more info. We need to build against Xcode 9 because Xcode 10 removes libstdc++.6.0.9 and CardFlight v3 requires it to link against. To that end, I'm merging into the
Xcode-9branch, which can run parallel tomasterfor now.In the mean time, this PR also includes a fix for the initial problem that prompted me to upgrade to CardFlight 4:
2a2a48f