Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore: CircleCI performance improvements on PRs" #10246

Conversation

olerichter00
Copy link
Contributor

Reverting the CircleCI performance improvements because of this issue: https://artsy.slack.com/archives/C02BAQ5K7/p1715860848940189?thread_ts=1715857924.392849&cid=C02BAQ5K7

I found something odd. Although the test-js[ job](https://github.com/artsy/eigen/blob/231bb4d827aeff3e5ce1cd81a54765844346cde6/.circleci/config.yml#L529) is not supposed to run on PRs (and it's not running in CircleCI), it's still required in the PR and shows a Expected — Waiting for status to be reported message...

Reverts #9993

@ArtsyOpenSource
Copy link
Contributor

Warnings
⚠️

An error occurred while validating your changelog, please make sure you provided a valid changelog.

Generated by 🚫 dangerJS against 2e965bb

@olerichter00 olerichter00 self-assigned this May 16, 2024
@olerichter00 olerichter00 merged commit f36e4a8 into main May 16, 2024
7 checks passed
@olerichter00 olerichter00 deleted the revert-9993-olerichter00/circleci-test-performance-improvements branch May 16, 2024 12:40
olerichter00 added a commit that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants