chore(ONYX-1108): retrieve swa specialists data from MP #10456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariakoko
changed the title
MounirDhahri
previously approved these changes
Sep 11, 2024
| onInquiryPress: InqueryPress | ||
| } | ||
|
|
||
| const Specialist: React.FC<SpecialistProps> = ({ specialist, onInquiryPress }) => { |
There was a problem hiding this comment.
thought: Is there a particular need for this component to be moved within the Flatlist? the separation we had was nice
There was a problem hiding this comment.
Brought Specialist component back 👍
dariakoko
added
the
Squash On Green
|
Awesome 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves ONYX-1108
Currently, we fetch the specialists data from S3. Let’s query this data from MP instead.
Related MP PR: feat(onyx-878): Schema for Specialist bios by nickskalkin · Pull Request #5653 · artsy/metaphysics
Description
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.