chore: spike on skeletons #10545
Draft
chore: spike on skeletons #10545
+70
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MounirDhahri
force-pushed
the
feat/support-loading-skeleton
branch
from
328f187
to
812eec2
Compare
|
I could see this working for legacy sections which almost all appear. For the new experience, I worry that Metaphysics may have to load all of the related data in order to determine the visible, personalized sections for a given user. Requesting the sections first and the data next might end up doing twice the work. We can wait and see if that is indeed an issue though. |
|
When I tried this in Insomnia, I was actually able to get the available sections without MP needing to query other services and that resulted in a faster initial query. It doesn't however solve the issue of having no data available 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves []
Description
This is an early spike on how we can get the right skeletons ahead regardless of the rails order.
The idea here is simple, get the available sections and the order without data -> Use that for drawing skeletons while the data is coming from the nested query.
This adds of course an extra query to all home screen fetches - it is however a cheap one since does only one trip to MP and comes back without talking to any other services.
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.