-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(masonry): Migrate ArtistSeries Artworks to use MasonryTabs #10591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkartalis
force-pushed
the
gkartalis/artistSeries-masonry
branch
from
August 12, 2024 08:16
0d9ec13
to
c004b04
Compare
gkartalis
commented
Aug 12, 2024
gkartalis
force-pushed
the
gkartalis/artistSeries-masonry
branch
3 times, most recently
from
August 15, 2024 15:21
453e4f9
to
5369e38
Compare
gkartalis
force-pushed
the
gkartalis/artistSeries-masonry
branch
from
August 21, 2024 11:29
5369e38
to
27f20f0
Compare
gkartalis
force-pushed
the
gkartalis/artistSeries-masonry
branch
from
September 3, 2024 09:35
27f20f0
to
3a05e48
Compare
will attach the after video when my connection is better (in ~ 3-4 hours) |
araujobarret
previously approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work 💪
left minor comments only
brainbicycle
previously approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨ 🐎 looking great!
gkartalis
added
the
Squash On Green
A label to indicate that Peril should squash-merge this PR when all statuses are green
label
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Jira Synced
Squash On Green
A label to indicate that Peril should squash-merge this PR when all statuses are green
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves PHIRE-1111
Description
Refactors the ArtistSeries screen.
RPReplay_Final1723480948.MP4
RPReplay_Final1725383275.mov
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.