Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(masonry): Migrate ArtistSeries Artworks to use MasonryTabs #10591

Merged
merged 11 commits into from
Sep 6, 2024

Conversation

gkartalis
Copy link
Member

@gkartalis gkartalis commented Aug 9, 2024

This PR resolves PHIRE-1111

Description

Refactors the ArtistSeries screen.

  • Moves description and more series from this artist section on an about tab
  • Updates Artist component and follow artist button to use the updated design
  • adds pagination to the Artwork Tab
Before After
RPReplay_Final1723480948.MP4
RPReplay_Final1725383275.mov

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • refactor artist series artworks to use performant masonry grid - gkartalis

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@gkartalis gkartalis self-assigned this Aug 9, 2024
@gkartalis gkartalis force-pushed the gkartalis/artistSeries-masonry branch from 0d9ec13 to c004b04 Compare August 12, 2024 08:16
@gkartalis gkartalis force-pushed the gkartalis/artistSeries-masonry branch 3 times, most recently from 453e4f9 to 5369e38 Compare August 15, 2024 15:21
@gkartalis gkartalis force-pushed the gkartalis/artistSeries-masonry branch from 5369e38 to 27f20f0 Compare August 21, 2024 11:29
@gkartalis gkartalis force-pushed the gkartalis/artistSeries-masonry branch from 27f20f0 to 3a05e48 Compare September 3, 2024 09:35
@gkartalis gkartalis marked this pull request as ready for review September 3, 2024 12:15
@gkartalis
Copy link
Member Author

will attach the after video when my connection is better (in ~ 3-4 hours)

@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Sep 3, 2024

This PR contains the following changes:

  • Cross-platform user-facing changes (refactor artist series artworks to use performant masonry grid - gkartalis)

Generated by 🚫 dangerJS against 7bd7660

araujobarret
araujobarret previously approved these changes Sep 4, 2024
Copy link
Contributor

@araujobarret araujobarret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work 💪

left minor comments only

brainbicycle
brainbicycle previously approved these changes Sep 4, 2024
Copy link
Contributor

@brainbicycle brainbicycle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ 🐎 looking great!

@gkartalis gkartalis added the Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green label Sep 6, 2024
@artsy-peril artsy-peril bot merged commit 7a209a7 into main Sep 6, 2024
7 checks passed
@artsy-peril artsy-peril bot deleted the gkartalis/artistSeries-masonry branch September 6, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jira Synced Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants