Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: New Works for You pagination #10647

Merged

Conversation

olerichter00
Copy link
Contributor

@olerichter00 olerichter00 commented Aug 22, 2024

This PR resolves ONYX-1174

Description

This PR implements pagination for the "New Works for You" screen. Before we always fetched 100 artworks.

Screenshot

Simulator Screenshot - iPhone 15 Plus - 2024-08-26 at 10 35 47

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • "New Works for You" screen pagination fix - ole

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@olerichter00 olerichter00 self-assigned this Aug 22, 2024
@olerichter00 olerichter00 marked this pull request as draft August 22, 2024 13:54
@ArtsyOpenSource
Copy link
Contributor

This PR contains the following changes:

  • Cross-platform user-facing changes ("New Works for You" screen pagination fix - ole)

Generated by 🚫 dangerJS against 1c7e652

@olerichter00 olerichter00 merged commit cfc0764 into main Aug 26, 2024
8 checks passed
@olerichter00 olerichter00 deleted the olerichter00/ONYX-1174/new-works-for-you-pagination branch August 26, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants