Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add latest activity rail #10648

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Conversation

MounirDhahri
Copy link
Member

@MounirDhahri MounirDhahri commented Aug 22, 2024

This PR resolves ONYX-1222

This PR is blocked by: artsy/metaphysics#5936

Description

This PR adds the latest activity rail home view section.

Still todo for tomorrow:

  • Add tests
  • Add href
Screen.Recording.2024-08-22.at.18.29.36.mov

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • add latest activity rail - mounir

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

anandaroop
anandaroop previously approved these changes Aug 23, 2024
Copy link
Member

@anandaroop anandaroop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

...ActivityRail_notificationsConnection @arguments(count: 10)
...ActivityRail_viewer @arguments(count: 10)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question (non-blocking): So this (and the associated relay noise) was to correct a pre-existing naming glitch, yes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it should have been _viewer instead

@MounirDhahri MounirDhahri force-pushed the feat/add-latest-activity-section branch from 069b0ad to 68f5983 Compare August 26, 2024 13:38
@MounirDhahri MounirDhahri marked this pull request as ready for review August 26, 2024 13:39
@ArtsyOpenSource
Copy link
Contributor

This PR contains the following changes:

  • Cross-platform user-facing changes (add latest activity rail - mounir)

Generated by 🚫 dangerJS against 68f5983

@MounirDhahri MounirDhahri merged commit da31370 into main Aug 26, 2024
8 checks passed
@MounirDhahri MounirDhahri deleted the feat/add-latest-activity-section branch August 26, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants