feat(EMI-2015): Add auction signals to artwork grid and rail components #10669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrSltun
deleted the
mrsltun/EMI-2015/add-auction-signals-to-artwork-grid-item-and-rail-card
branch
| collectorSignals, | ||
| auctionSignals, | ||
| }: { | ||
| artwork: Artwork |
There was a problem hiding this comment.
way nicer to read, thanks for the changes 💟
| * @example | ||
| * "$1,750 (2 bids)" | ||
| */ | ||
| export const saleMessageOrBidInfo = ({ |
There was a problem hiding this comment.
(not for now) Is it possible to move this to MP
There was a problem hiding this comment.
Maybe we should move it to MP instead of having the client figure it out, but currently we use it with feature flags, so perhaps we could move it after releasing the feature?
| <Flex flexDirection="row" alignItems="center" justifyContent="space-between"> | ||
| <Text variant="xs" color="black60"> | ||
| {!!collectorSignals?.auction?.lotWatcherCount | ||
| ? `${collectorSignals.auction.lotWatcherCount} Watchers` |
There was a problem hiding this comment.
is the lotWatcherCount always bigger than 2?
There was a problem hiding this comment.
just updated it in #10682
| } | ||
|
|
||
| const fragment = graphql` | ||
| fragment ArtworkAuctionTimer_collectorSignals on CollectorSignals { |
There was a problem hiding this comment.
I wonder what will be the impact of this fragment on the performance of the query - auctions used to not be the fastest thing we have 😄
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves EMI-2015
Note
The changes in this PR are hidden behind
AREnableAuctionImprovementsSignalsfeature flagDescription
This PR adds new signals for auctioned artworks in Artwork Grid items and Artwork Rail cards
Screenshots and videos
Screenshots and Videos
updating-lot-watchers-android.mov
updating-lot-watchers-ios.mov
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.