chore: rename homeview section names #10687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MounirDhahri
force-pushed
the
feat/rename-section-names
branch
from
324a690
to
f59983c
Compare
nickskalkin
previously approved these changes
Aug 30, 2024
| @@ -80,7 +80,6 @@ describe("SearchArtworks", () => { | |||
| "destination_screen_owner_type": "artwork", | |||
| "position": 0, | |||
| "query": "keyword", | |||
| "signal_label": "Limited-Time Offer", | |||
There was a problem hiding this comment.
question: Is this an intentional change?
anandaroop
previously approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Nice!
Looks good, but will probably need a schema bump after the code review changes in artsy/metaphysics#5962
MounirDhahri
dismissed stale reviews from anandaroop and nickskalkin
via
8884b7e
MounirDhahri
force-pushed
the
feat/rename-section-names
branch
2 times, most recently
from
8884b7e
to
2371fcf
Compare
MounirDhahri
force-pushed
the
feat/rename-section-names
branch
from
c7c802a
to
459102b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves ONYX-1242
Description
Rename HomeView section names
This PR is blocked by artsy/metaphysics#5962
Screen.Recording.2024-08-30.at.10.27.25.mov
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.