Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix broken tests #10690

Merged

Conversation

MrSltun
Copy link
Member

@MrSltun MrSltun commented Aug 30, 2024

This PR resolves []

Description

This PR fixes another test 😅

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.

#nochangelog

Need help with something? Have a look at our docs, or get in touch with us.

@MrSltun MrSltun self-assigned this Aug 30, 2024
@MrSltun MrSltun added the Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green label Aug 30, 2024
@MounirDhahri
Copy link
Member

I've done the same thing here but didn't succeed. Let's see how it goes this time

@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Aug 30, 2024

Warnings
⚠️

No changelog changes

Generated by 🚫 dangerJS against 2f54d57

@MrSltun
Copy link
Member Author

MrSltun commented Aug 30, 2024

@MounirDhahri I think it's because I marked collectorSignals as null in #10684, and because of that, it doesn't include that in the tracking event

@artsy-peril artsy-peril bot merged commit b47e6bd into main Aug 30, 2024
7 checks passed
@artsy-peril artsy-peril bot deleted the mrsltun/fix/broken-collector-signal-tracking-tests-2.0 branch August 30, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants