Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix issue with opening a conversation notification when the app is closed #10695

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

MrSltun
Copy link
Member

@MrSltun MrSltun commented Aug 30, 2024

This PR resolves []

Description

This PR fixes the issue of tapping on a conversation notification when the app is closed on Android

Videos

Before After
notification-closed-before.mp4
notification-closed-after.mp4

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • fix opening conversation notification when the app is closed - mrsltun

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@MrSltun MrSltun self-assigned this Aug 30, 2024
@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Aug 30, 2024

This PR contains the following changes:

  • Cross-platform user-facing changes (fix opening conversation notification when the app is closed - mrsltun)

Generated by 🚫 dangerJS against 329d2c5

@brainbicycle
Copy link
Contributor

Looks good! non-blocking but wondering if we should make me explicitly nullable in the props to make it obvious it should be checked before accessing?

brainbicycle
brainbicycle previously approved these changes Aug 30, 2024
@MrSltun
Copy link
Member Author

MrSltun commented Sep 3, 2024

@brainbicycle adding a null type breaks the typing in the file 👀
but I think it's breaking on Android because it's trying to use the me namespace before it's loaded, hence it's breaking
I was thinking of adding a suspense to the query renderer to see how would that work, but I can check it in a follow-up PR if that's okay

@MrSltun MrSltun merged commit c1990a4 into main Sep 3, 2024
7 checks passed
@MrSltun MrSltun deleted the mrsltun/fix/android-notification-unable-to-load branch September 3, 2024 14:04
MrSltun added a commit that referenced this pull request Sep 3, 2024
…is closed (#10695)

* fix: Attempt to fix issue with closed app notification

* add suspense to inbox

* Revert "add suspense to inbox"

This reverts commit 001934d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants