Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MP query freshness checker prototype #4462

Merged
merged 28 commits into from
Feb 27, 2021
Merged

MP query freshness checker prototype #4462

merged 28 commits into from
Feb 27, 2021

Conversation

pvinis
Copy link
Contributor

@pvinis pvinis commented Feb 19, 2021 •
edited
Loading

The type of this PR is: TYPE

This PR resolves [CX-]

Description

This PR is ready. It will take a bunch of our eigen queries and run them against MP and complain if any fails.

Next steps:

  • Use users with funky accounts

PR Checklist (tick all before merging)

  • I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
  • I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added an app state migration, or my changes do not require one. (What are migrations?)
  • I have added a CHANGELOG.yml entry or my changes do not require one.

@pvinis pvinis changed the title first try MP query freshness checker Feb 19, 2021
@pvinis pvinis changed the title MP query freshness checker MP query freshness checker prototype Feb 19, 2021
@pvinis pvinis marked this pull request as ready for review February 26, 2021 11:18
@pvinis pvinis requested a review from ds300 February 26, 2021 11:18
ds300
ds300 approved these changes Feb 26, 2021
View reviewed changes
Copy link
Contributor

@ds300 ds300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@ds300 ds300 merged commit d95bc8f into master Feb 27, 2021
@ds300 ds300 deleted the mp-queries-tester branch February 27, 2021 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ds300 ds300 ds300 approved these changes

Assignees

@ds300 ds300

Labels
Jira Synced
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pvinis @ds300