Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: android consign photos action sheet #4535

Merged
merged 11 commits into from
Mar 18, 2021
Merged

fix: android consign photos action sheet #4535

merged 11 commits into from
Mar 18, 2021

Conversation

brainbicycle
Copy link
Contributor

@brainbicycle brainbicycle commented Mar 16, 2021 •
edited by bhoggard
Loading

The type of this PR is: fix

This PR resolves CX-1154

Description

Our current method for showing action sheets is iOS only, this PR replaces that dependency with @expo/react-native-action-sheet which is cross platform and has the same API as the old ActionSheetIOS dependency. It requires wrapping our app in an ActionSheetProvider object.

Screenshots

Android

consignments-photos.mp4

iOS

  • UX is the same as previously

PR Checklist (tick all before merging)

  • I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
  • I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added an app state migration, or my changes do not require one. (What are migrations?)
  • I have added a CHANGELOG.yml entry or my changes do not require one.

@brainbicycle brainbicycle marked this pull request as draft March 16, 2021 19:33
@brainbicycle brainbicycle requested review from ds300 and bhoggard March 16, 2021 19:34
@brainbicycle brainbicycle force-pushed the b+b/android-consign-photos branch from dfb10d1 to 1e31c64 Compare March 16, 2021 20:12
@brainbicycle brainbicycle marked this pull request as ready for review March 16, 2021 20:16
ds300
ds300 approved these changes Mar 17, 2021
View reviewed changes
Copy link
Contributor

@ds300 ds300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! 👍🏼

src/lib/Scenes/Consignments/Screens/Overview.tsx Outdated Show resolved Hide resolved
brainbicycle and others added 2 commits March 17, 2021 15:51
@MounirDhahri MounirDhahri merged commit 3d57549 into master Mar 18, 2021
@MounirDhahri MounirDhahri deleted the b+b/android-consign-photos branch March 18, 2021 12:30
@MounirDhahri
Copy link
Member

📦

@brainbicycle brainbicycle mentioned this pull request Mar 25, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MounirDhahri MounirDhahri MounirDhahri approved these changes

@ds300 ds300 ds300 approved these changes

@bhoggard bhoggard Awaiting requested review from bhoggard

Assignees

@MounirDhahri MounirDhahri

Labels
Jira Synced
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brainbicycle @MounirDhahri @ds300