Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow action sheets to open in front of modals #5664

Conversation

olerichter00
Copy link
Contributor

@olerichter00 olerichter00 commented Oct 19, 2021

The type of this PR is: Bugfix

This PR resolves CX-2044

Description

Allows action sheets to open in front of modals on Android by wrapping the ActionSheet with a modal using the useModal option (react-native-action-sheet issue reference).

iOS Before iOS After Android After
ios before ios after android after

PR Checklist (tick all before merging)

  • I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
  • I have tested my changes on iOS and Android.
  • I have added tests/stories for my changes, or my changes don't require testing/stories, or I have included a link to a separate Jira ticket covering the tests.
  • I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added an app state migration, or my changes do not require one. (What are migrations?)
  • I have added a changelog entry below or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Oct 19, 2021

Warnings
⚠️

An error occurred while validating your changelog, please make sure you provided a valid changelog.

Generated by 🚫 dangerJS against 532d178

@olerichter00 olerichter00 force-pushed the olerichter00/CX-2044/allow-action-sheets-to-open-in-front-of-modals branch from 4af830d to 532d178 Compare October 19, 2021 12:37
Copy link
Member

@MounirDhahri MounirDhahri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@MounirDhahri MounirDhahri merged commit d229db0 into master Oct 20, 2021
@MounirDhahri MounirDhahri deleted the olerichter00/CX-2044/allow-action-sheets-to-open-in-front-of-modals branch October 20, 2021 09:47
rajsam003 pushed a commit that referenced this pull request Oct 27, 2021
* fix: Allow action sheets to open in front of modals

* fix delete button
Gon4ar5 pushed a commit that referenced this pull request Oct 27, 2021
* fix: Allow action sheets to open in front of modals

* fix delete button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants