Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: context menu [anyone can take this over] #7704

Closed
wants to merge 7 commits into from
Closed

feat: context menu [anyone can take this over] #7704

wants to merge 7 commits into from

Conversation

pvinis
Copy link
Contributor

@pvinis pvinis commented Nov 21, 2022

This PR resolves []

Description

could be split into two PRs, one for the global sharesheet, the other for the context menu, they are only blocking each other for the "share" action

  • havent checked whats up with android
  • needs some padding so the hover effect is nicer when context menu is showing
  • tests need rewriting
  • sharesheet needs to handle the artwork/artist/sale queries and analytics calls
Screen.Recording.2022-12-25.at.17.49.53.mov

PR Checklist

  • I tested my changes on iOS / Android.
  • I added screenshots or videos to illustrate my changes.
  • I added Tests and Stories for my changes.
  • I added an app state migration.
  • I hid my changes behind a feature flag.
  • I have prefixed changes that need to be tested during a release QA with [NEEDS EXTERNAL QA] on the changelog.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@pvinis pvinis changed the title trial: context menu trial: context menu [anyone can take this over] Dec 25, 2022
@pvinis pvinis changed the title trial: context menu [anyone can take this over] feat: context menu [anyone can take this over] Dec 25, 2022
@gkartalis gkartalis self-assigned this Apr 20, 2023
@gkartalis
Copy link
Member

Closing this since we addressed part one here and currently working on part 2 which involves introducing react-native-context-menu-view and adding the functionality

@gkartalis gkartalis closed this Apr 27, 2023
@gkartalis gkartalis deleted the context branch April 27, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants