feat(ONYX-149): trigger mutations on artist preview bottom sheet #9034
Conversation
MounirDhahri
force-pushed
the
feat/ONYX-149/trigger-mutations-on-artist-preview-bottom-sheet
branch
from
5e4e881
to
b23060a
Compare
MounirDhahri
force-pushed
the
feat/ONYX-149/trigger-mutations-on-artist-preview-bottom-sheet
branch
from
b23060a
to
edece5f
Compare
| input, | ||
| }, | ||
| // @ts-expect-error | ||
| optimisticResponse: { |
There was a problem hiding this comment.
added this for a better ux
| variables: { | ||
| input, | ||
| }, | ||
| // @ts-expect-error |
There was a problem hiding this comment.
types are old here because of some relay types weirdness, we should at some point fix this everywhere in Eigen
| keyExtractor={({ internalID }) => internalID!} | ||
| data={filteredUserInterests} | ||
| renderItem={({ item }) => { | ||
| if (item?.node && item.internalID && item.node.internalID) { |
There was a problem hiding this comment.
this is never going to be null because we're checking for it above this call. I added this to make typescript happy
There was a problem hiding this comment.
suggestion / non-blocking: very tiny suggestion, I think this can be written as
item.internalID && item.node?.internalID
|
@dariakoko I will merge this to make sure you can continue on the work on showing the privacy icon next to the artist name |
MounirDhahri
deleted the
feat/ONYX-149/trigger-mutations-on-artist-preview-bottom-sheet
branch
|
|
||
| if (!collectedArtists) return <></> | ||
|
|
||
| const filteredUserInterests = userInterests.filter((userInterest) => { | ||
| if (userInterest?.internalID && userInterest.node && userInterest.node.internalID) { |
There was a problem hiding this comment.
suggestion / non-blocking: very tiny suggestion, I think this can be written as
userInterest?.internalID && userInterest.node?.internalID| keyExtractor={({ internalID }) => internalID!} | ||
| data={filteredUserInterests} | ||
| renderItem={({ item }) => { | ||
| if (item?.node && item.internalID && item.node.internalID) { |
There was a problem hiding this comment.
suggestion / non-blocking: very tiny suggestion, I think this can be written as
item.internalID && item.node?.internalID
This PR resolves ONYX-149
Description
This PR adds the missing mutations to the artist preview bottom sheet
Screen.Recording.2023-07-25.at.13.29.30.mov
PS: After recording the video, I realized it's not good UX to delete the artist immediately and added an alert first.
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.