build(deps): remove iso8601 dep #9368
Draft
+11
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brainbicycle
commented
Oct 3, 2023
| @@ -75,7 +75,7 @@ class LiveAuctionEventViewModel: NSObject, LiveAuctionEventViewModelType { | |||
| } | |||
|
|
|||
| var dateEventCreated: Date { | |||
| return ARStandardDateFormatter.shared().date(from: event.createdAtString) | |||
There was a problem hiding this comment.
this was actually nullable before but not specified in Obj-C code, so in theory this is no more dangerous, still worth thinking about handling nils if we are going to continue using native live auctions for a long time
brainbicycle
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves []
Description
Removes iso8601 dep specified in podfile, there is a date formatter now built in foundation for the same purpose.
We are still pulling in this dep as a transitive dep from Aerodramus but this gets us closer to getting rid of it.
Worth some focused testing! Live auctions and some api calls depend on this functionality!
Draft until I do some testing :)
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.