Merge branch 'master' into bottom-button

.gitignore

@@ -45,3 +45,7 @@ coverage
 # Use a custom, cached location for Jest to save transpiling
 # on every PR
 .jest/cache
+
+# A commit deploy using `yarn bundle-with-storybooks` generates these
+Emission.js
+Emission.js.meta

.travis.yml

@@ -5,8 +5,9 @@ node_js:
   - "6.7"
 
 script:
+  - scripts/deploy_commit.sh
   - yarn ci
-  - yarn danger -- run -t
+  - yarn danger
 
 deploy:
   provider: script

dangerfile.ts

@@ -158,5 +158,6 @@ const newBody = userBody + splitter + "\n" + bodyFooter
 // require Danger to submit a new body (and thus overwrite those changes.)
 const neuterMarkdownTicks = /- \[*.\]/g
 if (pr.body.replace(neuterMarkdownTicks, "-") !== newBody.replace(neuterMarkdownTicks, "-")) {
-  danger.github.api.pullRequests.update({...danger.github.thisPR, body: newBody })
+  // See https://github.com/artsy/emission/issues/589
+  // danger.github.api.pullRequests.update({...danger.github.thisPR, body: newBody })
 }

package.json

@@ -5,6 +5,7 @@
   "main": "index.ios.js",
   "scripts": {
     "bundle": "react-native bundle --config \"$(pwd)\"/rn-cli.config.js --platform=ios --dev=false --entry-file=index.ios.js --bundle-output Pod/Assets/Emission.js --sourcemap-output Pod/Assets/Emission.js.map --assets-dest Pod/Assets && rm -rf Pod/Assets/assets/node_modules",
+    "bundle-with-storybooks": "react-native bundle --config \"$(pwd)\"/rn-cli.config.js --platform=ios --dev=true --entry-file=Example/Emission/index.ios.js --bundle-output Emission.js --assets-dest Pod/Assets",
     "clean-example": "cd Example && xcodebuild -workspace Emission.xcworkspace -scheme Emission -destination 'platform=iOS Simulator,name=iPhone 6' clean",
     "type-check": "tsc --noEmit --pretty",
     "lint": "tslint 'src/**/*.{ts,tsx}'",

scripts/deploy_commit.sh

@@ -0,0 +1,15 @@
+#!/bin/sh
+
+if [ -z "$TRAVIS_PULL_REQUEST" ]; then
+    echo "Skipping deploy of the commit"
+    exit 0
+fi
+
+# Give us a CLI to work with
+yarn global add s3-cli
+
+# Createa bundle with embedded storybooks also into Emission.js
+yarn bundle-with-storybooks
+
+# Uploads the file to our s3 bucket - credentials are in the ENV vars for same-repo PRs
+s3-cli put Emission.js "s3://artsy-emission-js/$TRAVIS_PULL_REQUEST.js"