Skip to content
This repository has been archived by the owner on Mar 12, 2020. It is now read-only.

[Danger] Switch to Danger JS #trivial #385

Merged
merged 6 commits into from
Oct 29, 2016
Merged

[Danger] Switch to Danger JS #trivial #385

merged 6 commits into from
Oct 29, 2016

Conversation

orta
Copy link
Contributor

@orta orta commented Oct 28, 2016

Ruby is so 2015.

This moves us to DangerJS 0.0.10 - which should be enough to not be annoying. Does have rough edges though probably. It is enough to be usable in production IMO.

This is the first time I've tried using require in a DangerJS file, so err, our milage there may vary.

@orta
Copy link
Contributor Author

orta commented Oct 28, 2016

Aww:

> emission@1.1.1 danger /home/travis/build/artsy/emission
> danger
OK
module.js:440
    throw err;
    ^
Error: Cannot find module './travis'
    at Function.Module._resolveFilename (module.js:438:15)
    at Function.Module._load (module.js:386:25)
    at Module.require (module.js:466:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/home/travis/build/artsy/emission/node_modules/danger/distribution/ci_source/ci_source.js:11:15)
    at Module._compile (module.js:541:32)
    at Object.Module._extensions..js (module.js:550:10)
    at Module.load (module.js:456:32)
    at tryModuleLoad (module.js:415:12)
    at Function.Module._load (module.js:407:3)

@orta orta changed the title [Danger] Switch to Danger JS [WIP] [Danger] Switch to Danger JS Oct 28, 2016
@orta orta force-pushed the orta-danger-js branch 3 times, most recently from cc38319 to 2e1ce5b Compare October 29, 2016 08:36
@orta
Copy link
Contributor Author

orta commented Oct 29, 2016

OK, so it was a syntax error in my Dangerfile

@orta orta force-pushed the orta-danger-js branch 3 times, most recently from 358aca2 to 9b67c0b Compare October 29, 2016 08:56
@orta orta changed the title [WIP] [Danger] Switch to Danger JS [Danger] Switch to Danger JS #trivial Oct 29, 2016
@orta orta force-pushed the orta-danger-js branch 4 times, most recently from 056d425 to cc1b96c Compare October 29, 2016 09:13
@orta
Copy link
Contributor Author

orta commented Oct 29, 2016

OK, this is good to go on green.

@orta orta merged commit c558323 into master Oct 29, 2016
@orta orta deleted the orta-danger-js branch October 29, 2016 09:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant