This repository has been archived by the owner on Mar 12, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 78
[WIP] Typescript conversion #438
Closed
Closed
Changes from 12 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
22b5aa7
[package] Update to React Native 0.40.0
alloy 669733b
[package] Switch to fork of RN master that has fixed podspec.
alloy 7f7ca64
[ImageView] Switch to using Yoga’s API.
alloy 220fc40
[Typescript] Initial project conversion
l2succes 91d9335
[Typescript] Fixes just enough to get the code to compile and run
l2succes 156c480
[Typescript] fixes type issues for Gene container and sub components
l2succes 85f2cee
[Typescript] Adds relay interfaces using relay2ts
l2succes 63f49a9
[Typescript] Removes storybook file in Example
l2succes fb5d65c
[Typescript] Fixes tests
l2succes 230a153
[TypeScript] Fixes most type errors in artist components
sarahscott 1f26cdd
[TypeScript] Finishes artist components
sarahscott 773dcf7
stash
alloy 7573b8c
[Typescript] rename relay interfaces
l2succes a48d856
[Typescript] reset Podfile.lock changes
l2succes be03af7
[Typescript] removes storybook from Example app entrypoint
l2succes a954e12
[Typescript] get tests to run locally
l2succes 402f452
[Typescript] converted tests to typscript
l2succes 5775c52
[pod] Update to RN 0.42.0-rc2
alloy 5c1fd4f
[Typescript] updated jest and tests
l2succes 994a990
Adds .nvmrc
l2succes de6f431
[Typescript] Fixes tests
l2succes 9ae1d9e
[OpaqueImageView] RN now has built-in support for aspect ratios.
alloy 96ed06e
[Home/Artist] Ensure the rail fully takes up its height and pushes si…
alloy d6db12b
[vscode] Update recommended extensions
orta c7b3cc5
[Packages] Remove unused packages
orta da28aeb
Upgrades react-native/yoga to working version
l2succes 5baf183
Merge branch 'typescript' of github.com:artsy/emission into typescript
l2succes 1ac0388
[TypeScript] Converted load failure view to ts
sarahscott File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,6 +10,10 @@ | |
"jest": true | ||
}, | ||
|
||
"ignore": [ | ||
"build/**/*.js" | ||
], | ||
|
||
"plugins": [ | ||
"react", | ||
"flow-vars", | ||
|
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,32 @@ | ||
{ | ||
"version": "0.1.0", | ||
"command": "npm", | ||
"command": "sh", | ||
"args": ["-c"], | ||
"isShellCommand": true, | ||
"showOutput": "always", | ||
"showOutput": "silent", | ||
"suppressTaskName": true, | ||
"tasks": [ | ||
{ | ||
"taskName": "Start Packager and Storybook Server", | ||
"isBuildCommand": true, | ||
"args": ["start"] | ||
"args": ["npm start"] | ||
}, | ||
{ | ||
"taskName": "Start Typescript Compiler", | ||
"isBuildCommand": true, | ||
"args": ["tsc"], | ||
"problemMatcher": [ | ||
"$tsc" | ||
] | ||
}, | ||
{ | ||
"taskName": "Start Typescript Compiler (in watch mode)", | ||
"isBuildCommand": true, | ||
"args": ["tsc --watch"], | ||
"isWatching": true, | ||
"problemMatcher": [ | ||
"$tsc-watch" | ||
] | ||
} | ||
] | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,2 @@ | ||
/* @flow */ | ||
'use strict'; | ||
|
||
import 'emission'; | ||
import './storybook'; | ||
|
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,24 +1,21 @@ | ||
/* @flow */ | ||
'use strict'; | ||
|
||
import Emission from 'emission'; | ||
import React from 'react'; | ||
import ReactNative from 'react-native'; | ||
const { View } = ReactNative; | ||
const { TestModule } = ReactNative.NativeModules; | ||
import Emission from 'emission' | ||
import React from 'react' | ||
import ReactNative from 'react-native' | ||
const { View } = ReactNative | ||
const { TestModule } = ReactNative.NativeModules | ||
|
||
class OpaqueImageViewTest extends React.Component { | ||
assert() { | ||
TestModule.verifySnapshot(TestModule.markTestPassed); | ||
TestModule.verifySnapshot(TestModule.markTestPassed) | ||
} | ||
|
||
render() { | ||
return ( | ||
<View style={this.props.containerStyle}> | ||
<Emission.Components.OpaqueImageView {...this.props.imageView} onLoad={this.assert} /> | ||
</View> | ||
); | ||
) | ||
} | ||
} | ||
|
||
ReactNative.AppRegistry.registerComponent('OpaqueImageView', () => OpaqueImageViewTest); | ||
ReactNative.AppRegistry.registerComponent('OpaqueImageView', () => OpaqueImageViewTest) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
export default { | ||
"gray-light": "#f8f8f8", | ||
"gray-regular": "#e5e5e5", | ||
"gray-medium": "#cccccc", | ||
"gray-semibold": "#666666", | ||
"gray-bold": "#333333", | ||
"purple-light": "#e2d2ff", | ||
"purple-regular": "#6e1fff", | ||
"red-regular": "#f7625a", | ||
"yellow-regular": "#fdefd1", | ||
"yellow-medium": "#fce1a8", | ||
"yellow-bold": "#f1af1b", | ||
"green-regular": "#0eda83" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
declare const __DEV__: boolean; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn’t this be?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's correct, still working on converting all the tests. I'll have it updated soon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nah, just checked, this doesn't need to change - it's still a JS file, and should stay one probably. It's only referenced by the iOS Sim Test Runner.