Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add docs about adding a new app to SSR router #5661

Merged
merged 1 commit into from
May 28, 2020

Conversation

damassi
Copy link
Member

@damassi damassi commented May 28, 2020

This adds some docs around adding a new app / route to force, via our SSR router.

@damassi damassi requested review from dzucconi and zephraph May 28, 2020 00:26
@damassi damassi force-pushed the add-docs-around-new-app branch from 0d57fa7 to c782739 Compare May 28, 2020 00:29
@ArtsyOpenSource
Copy link

ArtsyOpenSource commented May 28, 2020

Fails
🚫

Danger failed to run dangerfile.ts.

Error RangeError

Maximum call stack size exceeded
RangeError: Maximum call stack size exceeded
    at Object.parseExprAtom (/home/circleci/project/node_modules/@babel/core/node_modules/@babel/parser/lib/index.js:3600:16)
    at Object.parseExprSubscripts (/home/circleci/project/node_modules/@babel/core/node_modules/@babel/parser/lib/index.js:8483:23)
    at Object.parseMaybeUnary (/home/circleci/project/node_modules/@babel/core/node_modules/@babel/parser/lib/index.js:8463:21)
    at Object.parseExprOps (/home/circleci/project/node_modules/@babel/core/node_modules/@babel/parser/lib/index.js:8329:23)
    at Object.parseMaybeConditional (/home/circleci/project/node_modules/@babel/core/node_modules/@babel/parser/lib/index.js:8302:23)
    at Object.parseMaybeAssign (/home/circleci/project/node_modules/@babel/core/node_modules/@babel/parser/lib/index.js:8249:21)
    at Object.parseMaybeAssign (/home/circleci/project/node_modules/@babel/core/node_modules/@babel/parser/lib/index.js:2672:18)
    at Object.parseExprListItem (/home/circleci/project/node_modules/@babel/core/node_modules/@babel/parser/lib/index.js:9562:18)
    at Object.parseExprList (/home/circleci/project/node_modules/@babel/core/node_modules/@babel/parser/lib/index.js:9536:22)
    at Object.parseExprAtom (/home/circleci/project/node_modules/@babel/core/node_modules/@babel/parser/lib/index.js:8841:32)

Dangerfile

--------------------^

Generated by 🚫 dangerJS against 847034f

@damassi damassi force-pushed the add-docs-around-new-app branch from c782739 to 913139f Compare May 28, 2020 01:05
@damassi damassi force-pushed the add-docs-around-new-app branch 2 times, most recently from bb9358b to 847034f Compare May 28, 2020 01:53
@sweir27
Copy link
Contributor

sweir27 commented May 28, 2020

Thanks for adding this! The first time we add a new app from scratch into this framework, we should link to that PR as an example.

Would also love for some more explanation on why we do things a certain way, but I imagine that'll come in your lunch and learn and we can link/add here at that point.

@sweir27
Copy link
Contributor

sweir27 commented May 28, 2020

Not sure what the danger error is-- feel free to merge unless you're looking into that!

@damassi damassi merged commit 517079b into master May 28, 2020
@damassi damassi deleted the add-docs-around-new-app branch May 28, 2020 16:42
@artsy-peril artsy-peril bot mentioned this pull request May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants