feat: artwork page - link to user idv flow if applicable #6366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikdstock
commented
Sep 29, 2020
| @@ -18,7 +18,6 @@ import { ArtworkSidebarBidAction_me } from "v2/__generated__/ArtworkSidebarBidAc | |||
| import * as Schema from "v2/Artsy/Analytics/Schema" | |||
| import track from "react-tracking" | |||
| import { getENV } from "v2/Utils/getENV" | |||
| import { bidderNeedsIdentityVerification } from "v2/Utils/identityVerificationRequirements" | |||
There was a problem hiding this comment.
I have now factored this out of two files (the other being Registration.tsx) because we wanted more granular definitions of what to show a user something to consider.
Comment on lines
138
to
145
| const userLacksIdentityVerification = | ||
| sale.requireIdentityVerification && !me?.identityVerified | ||
| const pendingIdentityVerification = me?.pendingIdentityVerification | ||
|
|
||
| const shouldPromptIdVerification = | ||
| !qualifiedForBidding && | ||
| userLacksIdentityVerification && | ||
| Boolean(pendingIdentityVerification) |
There was a problem hiding this comment.
Maybe the function i have been removing should actually be updated to return an interface full of idv-related properties like this instead.
There was a problem hiding this comment.
I think this is fine, as long as the login remains confined to this component.
bhoggard
approved these changes
Sep 29, 2020
|
Thanks for using semantic style of the PR title! 🙌 Strictly speaking, there isn't an |
erikdstock
force-pushed
the
es-user-idv-ctas
branch
from
1923e84 to
7b74da8
Compare
erikdstock
changed the title
|
@bhoggard, this is now complete and ready for squash/merge. |
|
#squashongreen |
erikdstock
force-pushed
the
es-user-idv-ctas
branch
from
7b74da8 to
d39d6a9
Compare
artsy-peril
bot
added
the
Squash On Green
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the link-to-identity-verification functionality similar to #6342 to our artwork pages, prompting a user with a pending identity verification to complete it. The affected component contains logic for several different sale types but i have only added a test for one of them - something probably worth addressing. There is also some basically duplicated logic between this and Registration.tsx, which is for the sale page and does not use relay.