[FX-2189] Implements bare-bones show route #6408
Conversation
| {show.name} | ||
| </Text> | ||
|
|
||
| <Separator as="hr" my={3} /> |
There was a problem hiding this comment.
🧐 TIL Separator is not an hr to begin with
There was a problem hiding this comment.
Yeah, I think it should be. Will PR that at some point...
| const getWrapper = () => { | ||
| return mount(<ShowApp show={SHOW_FIXTURE as any} />) | ||
| } |
There was a problem hiding this comment.
Makes sense, but is this simplified version just a placeholder till the new Relay mocking patterns land in Force?
There was a problem hiding this comment.
Yeah, or until we need to test something more complex. Like, what are we trying to test really
| show: { name, slug, metaDescription, metaImage }, | ||
| }) => { | ||
| const title = `${name} | Artsy` | ||
| const href = `${getENV("APP_URL")}/show/${slug}` |
There was a problem hiding this comment.
Confirming that /show/ here is deliberate even though this page lives at /show2/ for now
There was a problem hiding this comment.
Yeah, this was intentional since we'll never launch it with show2, though I can change it to show2 if that's less confusing for now.
Closes: FX-2189