[v2] Remove Viewer type. Relay Modern no longer needs this proxy. #1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add some more context? I was trying to follow along w/ the graphql slack conversation, but I don't fully understand this or why it was needed to begin with. |
|
Done. Let me know if that helps. |
|
Is this blocked waiting on the Emission PR? |
|
@zephraph Yup, but that’s up now too, so this is ready to review/merge 👍 |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://artsyproduct.atlassian.net/browse/PLATFORM-1718
Emission PR: artsy/emission#1818
Relay Classic had a few constraints on root fields, which are described in facebook/relay#112. A common workaround, which originated with FB, was to have a root field that would proxy all the root fields. This was often done on a field called
viewer.Besides Relay Modern no longer having these constraints, I also think that we should reserve the name
viewerfor any potential future case where we want to represent e.g. the user looking at the site/app, perhaps aside fromme.