fix(home view): use correct Quick Links data #6450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandaroop
force-pushed
the
anandaroop/ONYX-1484-pill-icons
branch
from
7055bdf to
b9a035b
Compare
anandaroop
force-pushed
the
anandaroop/ONYX-1484-pill-icons
branch
from
b9a035b to
9d10ac4
Compare
anandaroop
commented
Feb 19, 2025
Comment on lines
+49
to
+52
| // TODO: enable once navigation is sorted out | ||
| // { | ||
| // title: "Medium", | ||
| // href: "/collections-by-category/Medium", |
There was a problem hiding this comment.
This one is tough! I tried to build the correct href, but failed because of the unusual way in which we are routing from the home view to those screens. This will need some attention, but we can also merge here and follow up.
dariakoko
previously approved these changes
Feb 20, 2025
MounirDhahri
previously approved these changes
Feb 20, 2025
| }, | ||
|
|
||
| // TODO: enable once eigen/11476 is merged |
There was a problem hiding this comment.
we might need at some point to support some versioning here - definitely not needed for now
There was a problem hiding this comment.
@MounirDhahri yeah that's a good point, worth some discussion.
anandaroop
dismissed stale reviews from MounirDhahri and dariakoko
via
f5005a1
|
Cool, I've resolved those analytics todos, and will merge this now as well |
anandaroop
added
the
Squash On Green
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://artsyproduct.atlassian.net/browse/ONYX-1554
Update to artsy/eigen#11528
See: Slack comment
Updates Quick Links to use correct pill names, destinations, and icons.
This will result in the following change in Eigen:
Note that two of the required pills are still missing:
Those are included but commented out here. They can be updated as a follow-up.