feat: allow VisualClue color to be customized #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artsy-peril
bot
added
Jira Synced
anandaroop
force-pushed
the
anandaroop/ONYX-1463-visual-clue
branch
from
d57bd9a to
80ea44c
Compare
anandaroop
added
the
Squash On Green
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This depends on the updated tokens from artsy/palette#1415
This PR resolves ONYX-1463
Description
In order to run an experiment with visual indicator colors, we need to be able pass in a custom color to the
VisualCluecomponentThe accompanying story now documents the customizable colors and (already) customizable diameters for this component: