Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@eessex => Add section types to Looker export #1218

Merged
merged 2 commits into from
Aug 9, 2017
Merged

@eessex => Add section types to Looker export #1218

merged 2 commits into from
Aug 9, 2017

Conversation

kanaabe
Copy link
Contributor

@kanaabe kanaabe commented Aug 9, 2017

Exports a column record like:

"[{'type':'artworks'},{'type':'text'},{'type':'artworks'},{'type':'text'},{'type':'artworks'},{'type':'text'}]"

in a sections and hero_section field so we can query things like, "all articles with a fullscreen header" or "all articles without a text section".

eessex
eessex approved these changes Aug 9, 2017
View reviewed changes
Copy link
Contributor

@eessex eessex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@eessex eessex merged commit fc41010 into artsy:master Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eessex eessex eessex approved these changes

Assignees

@eessex eessex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kanaabe @eessex