Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refer to @artsy/express-reloadable #1239

Merged
merged 1 commit into from
Aug 17, 2017
Merged

Refer to @artsy/express-reloadable #1239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions boot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import express from 'express'
import newrelic from 'artsy-newrelic'
import path from 'path'
import { IpFilter } from 'express-ipfilter'
import { createReloadable, isDevelopment } from 'lib/reloadable'
import { createReloadable, isDevelopment } from '@artsy/express-reloadable'

const debug = require('debug')('app')
const app = module.exports = express()
Expand All @@ -28,7 +28,7 @@ artsyXapp.init(xappConfig, () => {
app.use(newrelic)

if (isDevelopment) {
const reloadAndMount = createReloadable(app)
const reloadAndMount = createReloadable(app, require)

// Enable server-side code hot-swapping on change
app.use('/api', reloadAndMount(path.resolve(__dirname, 'api'), {
Expand Down
75 changes: 0 additions & 75 deletions lib/reloadable.js
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
"deploy": "sh scripts/deploy.sh"
},
"dependencies": {
"@artsy/express-reloadable": "^1.0.2",
"@artsy/reaction-force": "^0.1.49",
"airtable": "^0.4.5",
"artsy-backbone-mixins": "git://github.com/artsy/artsy-backbone-mixins.git",
Expand Down
6 changes: 6 additions & 0 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@
# yarn lockfile v1


"@artsy/express-reloadable@^1.0.2":
version "1.0.2"
resolved "https://registry.yarnpkg.com/@artsy/express-reloadable/-/express-reloadable-1.0.2.tgz#c63adeb7682334cfa5bf66c92fb9aaea062bda47"
dependencies:
chokidar "^1.7.0"

"@artsy/reaction-force@^0.1.49":
version "0.1.49"
resolved "https://registry.yarnpkg.com/@artsy/reaction-force/-/reaction-force-0.1.49.tgz#3899011c56a37b9fdeb92e06532ddc40d3fb4a8d"
Expand Down