@kanaabe => Upgrade to React 16 + Enzyme 3 #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
damassi
force-pushed
the
upgrade-react-16
branch
from
f9cff4a to
7de6c59
Compare
kanaabe
reviewed
Dec 21, 2017
|
|
||
| # Patch React 16 with deprecated helpers. Can remove once CoffeeScript goes away | ||
| React.DOM = DOM | ||
| React.createClass = createClass |
There was a problem hiding this comment.
Oh nice, we were wondering about how we would do this :)
|
Wow @damassi this is legit 👍 . Once the tests pass (and feel free to continue pending things if it becomes too much of a pain), let's merge and make sure staging looks great. I created a card so we don't forget to address them. |
|
Alright! this should be ready to go |
|
All of the Enzyme 3 changes were tough! make sure to check out the migration guide and let me know when y'all have looked into the |
damassi
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates minor semver packages via
yarn upgrade-interactive, updates React to 16 and Enzyme to 3. For enzyme in particular, read over the migration guide as there are a handful of breaking changes and (this issue might also be good to read.There were a few places where I've added
FIXME TEST:as I couldn't quite figure out how to fix, but should be quick to go over once merged.