feat: add constraints #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RealAnna
force-pushed
the
feat/add_constraints
branch
from
4915534 to
5a604fe
Compare
This was referenced Feb 20, 2023
arttor
requested changes
Feb 25, 2023
Signed-off-by: RealAnna <anna.reale@dynatrace.com> feat: added constraints Signed-off-by: RealAnna <anna.reale@dynatrace.com> feat: introduce topologyConstraints, node selectors and tolerations Signed-off-by: RealAnna <anna.reale@dynatrace.com> feat: added node selector and tolerations Signed-off-by: RealAnna <anna.reale@dynatrace.com> feat: added node selector and tolerations Signed-off-by: RealAnna <anna.reale@dynatrace.com> feat: added topologyConstraint Signed-off-by: RealAnna <anna.reale@dynatrace.com> feat: introduce topologyConstraints Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
RealAnna
force-pushed
the
feat/add_constraints
branch
from
c892ec8 to
0dee285
Compare
arttor
requested changes
Mar 13, 2023
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
arttor
approved these changes
Mar 13, 2023
arttor
reviewed
Mar 13, 2023
| secretName: {{ include "operator.fullname" . }}-secret-ca | ||
| {{- if .Values.topologySpreadConstraints }} | ||
| topologySpreadConstraints: {{- include "tplvalues.render" (dict "value" .Values.topologySpreadConstraints "context" $) | nindent 8 }} |
There was a problem hiding this comment.
There are 2 topologySpreadConstraints. Here and on line 107
There was a problem hiding this comment.
Sorry @RealAnna i had to revert constraints feature in this commit because of duplicates in specs. Commit also contains a template for nodeSelector which can be used as an example for other specs.
|
will this be added back? |
|
@luisdavim i suggest creating a new issue and listing specs to be templated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr adds topology constraints node selector and tolerations templates