Implement simple "seller extractor" script #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @BergFulton, any luck with this issue/PR? |
|
Hey @ndedic ! Thanks for working on this- things went a bit off the rails lately so I'm still reviewing this. I'll be back w/you soon. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
There is an extract_seller_json.php script in /scripts file which ingests Graves_Art_Sales.json and produces json file with extracted seller name. Generated json file will be located in scripts folder. It's a quick implementation, and it's not the cleanest code out there but hopefully it does the job as there are a lot of different edge cases.