Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0.0-rc.15] Update user handling #67

Merged
merged 3 commits into from
Apr 6, 2023
Merged

[1.0.0-rc.15] Update user handling #67

merged 3 commits into from
Apr 6, 2023

Conversation

St4NNi
Copy link
Member

@St4NNi St4NNi commented Apr 6, 2023

A small update that further improves user-handling:

Changes

  • Add email to user
  • New convenience function GetAllUserPermissionsForProject to get all users including permissions for project
  • Update user email, that allows to unsubscribe via empty email

@St4NNi St4NNi requested a review from das-Abroxas April 6, 2023 09:21
@St4NNi St4NNi added the enhancement New feature or request label Apr 6, 2023
@St4NNi St4NNi added this to the V1.0.0 milestone Apr 6, 2023
das-Abroxas
das-Abroxas requested changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@das-Abroxas das-Abroxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes but lgtm 🙂

aruna/api/storage/services/v1/project_service.proto Outdated Show resolved Hide resolved
@St4NNi @das-Abroxas
fix: Update aruna/api/storage/services/v1/project_service.proto
827c407 
Co-authored-by: Jannis Hochmuth <jannis.hochmuth@gmail.com>
@St4NNi St4NNi merged commit cc4f63f into main Apr 6, 2023
@St4NNi St4NNi deleted the update-user-handling-2 branch April 6, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@das-Abroxas das-Abroxas das-Abroxas requested changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
V1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@St4NNi @das-Abroxas