React 16 peerDependencies fix #169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danseethaler
added a commit
to danseethaler/foreman
that referenced
this pull request
Oct 2, 2017
This PR is to prepare for and merge React@16.0.0 The current Foreman code is compliant with React@15.6.2 which means everything should work with React@16. I've looked through all the dependencies and made a list of necessary changes: react-komposer - PR open [here](arunoda/react-komposer#169) radium - PR open [here](FormidableLabs/radium#930) react-addons-test-utils - moved to `react-dom/test-utils` react-icons - PR open [here](react-icons/react-icons#117) react-modal - No pending PR - likely a good idea to use a package that utilizes the React@16 portal functionality [this may work](https://www.npmjs.com/package/react-portal) react-simple-di - PR open [here](kadirahq/react-simple-di#13) react-test-renderer - This is part of React itself react-transition-group - Upgraded to 1.2.1 to support React@16 react-treebeard - 2.0.3 should accept React@16. not sure why we're getting this error react-stubber - PR open [here](kadirahq/react-stubber#4) http://projects.theforeman.org/issues/21160
danseethaler
added a commit
to danseethaler/foreman
that referenced
this pull request
Oct 2, 2017
The current Foreman code is compliant with React@15.6.2 which means everything should work with React@16. I've looked through all the dependencies and made a list of necessary changes: react-komposer - PR open [here](arunoda/react-komposer#169) radium - PR open [here](FormidableLabs/radium#930) react-addons-test-utils - moved to `react-dom/test-utils` react-icons - PR open [here](react-icons/react-icons#117) react-modal - No pending PR - likely a good idea to use a package that utilizes the React@16 portal functionality [this may work](https://www.npmjs.com/package/react-portal) react-simple-di - PR open [here](kadirahq/react-simple-di#13) react-test-renderer - This is part of React itself react-transition-group - Upgraded to 1.2.1 to support React@16 react-treebeard - 2.0.3 should accept React@16. not sure why we're getting a peer dependency error react-stubber - PR open [here](kadirahq/react-stubber#4) http://projects.theforeman.org/issues/21160
danseethaler
added a commit
to danseethaler/foreman
that referenced
this pull request
Oct 2, 2017
This PR is to prepare for and merge React@16.0.0 The current Foreman code is compliant with React@15.6.2 which means everything should work with React@16. I've looked through all the dependencies and made a list of necessary changes: react-komposer - PR open [here](arunoda/react-komposer#169) radium - PR open [here](FormidableLabs/radium#930) react-addons-test-utils - moved to `react-dom/test-utils` react-icons - PR open [here](react-icons/react-icons#117) react-modal - No pending PR - likely a good idea to use a package that utilizes the React@16 portal functionality [this may work](https://www.npmjs.com/package/react-portal) react-simple-di - PR open [here](kadirahq/react-simple-di#13) react-test-renderer - This is part of React itself react-transition-group - Upgraded to 1.2.1 to support React@16 react-treebeard - 2.0.3 should accept React@16. not sure why we're getting a peer dependency error react-stubber - PR open [here](kadirahq/react-stubber#4) http://projects.theforeman.org/issues/21160
danseethaler
added a commit
to danseethaler/foreman
that referenced
this pull request
Oct 2, 2017
This PR is to prepare for and merge React@16.0.0 The current Foreman code is compliant with React@15.6.2 which means everything should work with React@16. I've looked through all the dependencies and made a list of necessary changes: react-komposer - PR open [here](arunoda/react-komposer#169) radium - PR open [here](FormidableLabs/radium#930) react-addons-test-utils - moved to `react-dom/test-utils` react-icons - PR open [here](react-icons/react-icons#117) react-modal - No pending PR - likely a good idea to use a package that utilizes the React@16 portal functionality [this may work](https://www.npmjs.com/package/react-portal) react-simple-di - PR open [here](kadirahq/react-simple-di#13) react-test-renderer - This is part of React itself react-transition-group - Upgraded to 1.2.1 to support React@16 react-treebeard - 2.0.3 should accept React@16. not sure why we're getting a peer dependency error react-stubber - PR open [here](kadirahq/react-stubber#4) http://projects.theforeman.org/issues/21160
danseethaler
added a commit
to danseethaler/foreman
that referenced
this pull request
Oct 4, 2017
This PR is to prepare for and merge React@16.0.0 The current Foreman code is compliant with React@15.6.2 which means everything should work with React@16. I've looked through all the dependencies and made a list of necessary changes: react-komposer - PR open [here](arunoda/react-komposer#169) radium - PR open [here](FormidableLabs/radium#930) react-addons-test-utils - moved to `react-dom/test-utils` react-icons - PR open [here](react-icons/react-icons#117) react-modal - No pending PR - likely a good idea to use a package that utilizes the React@16 portal functionality [this may work](https://www.npmjs.com/package/react-portal) react-simple-di - PR open [here](kadirahq/react-simple-di#13) react-test-renderer - This is part of React itself react-transition-group - Upgraded to 1.2.1 to support React@16 react-treebeard - 2.0.3 should accept React@16. not sure why we're getting a peer dependency error react-stubber - PR open [here](kadirahq/react-stubber#4) http://projects.theforeman.org/issues/21160
danseethaler
added a commit
to danseethaler/foreman
that referenced
this pull request
Oct 5, 2017
This PR is to prepare for and merge React@16.0.0 The current Foreman code is compliant with React@15.6.2 which means everything should work with React@16. I've looked through all the dependencies and made a list of necessary changes: react-komposer - PR open [here](arunoda/react-komposer#169) radium - PR open [here](FormidableLabs/radium#930) react-addons-test-utils - moved to `react-dom/test-utils` react-icons - PR open [here](react-icons/react-icons#117) react-modal - No pending PR - likely a good idea to use a package that utilizes the React@16 portal functionality [this may work](https://www.npmjs.com/package/react-portal) react-simple-di - PR open [here](kadirahq/react-simple-di#13) react-test-renderer - This is part of React itself react-transition-group - Upgraded to 1.2.1 to support React@16 react-treebeard - 2.0.3 should accept React@16. not sure why we're getting a peer dependency error react-stubber - PR open [here](kadirahq/react-stubber#4) http://projects.theforeman.org/issues/21160
danseethaler
added a commit
to danseethaler/foreman
that referenced
this pull request
Oct 11, 2017
This PR is to prepare for and merge React@16.0.0 The current Foreman code is compliant with React@15.6.2 which means everything should work with React@16. I've looked through all the dependencies and made a list of necessary changes: react-komposer - PR open [here](arunoda/react-komposer#169) radium - PR open [here](FormidableLabs/radium#930) react-addons-test-utils - moved to `react-dom/test-utils` react-icons - PR open [here](react-icons/react-icons#117) react-modal - No pending PR - likely a good idea to use a package that utilizes the React@16 portal functionality [this may work](https://www.npmjs.com/package/react-portal) react-simple-di - PR open [here](kadirahq/react-simple-di#13) react-test-renderer - This is part of React itself react-transition-group - Upgraded to 1.2.1 to support React@16 react-treebeard - 2.0.3 should accept React@16. not sure why we're getting a peer dependency error react-stubber - PR open [here](kadirahq/react-stubber#4) http://projects.theforeman.org/issues/21160
danseethaler
added a commit
to danseethaler/foreman
that referenced
this pull request
Oct 11, 2017
This PR is to prepare for and merge React@16.0.0 The current Foreman code is compliant with React@15.6.2 which means everything should work with React@16. I've looked through all the dependencies and made a list of necessary changes: react-komposer - PR open [here](arunoda/react-komposer#169) radium - PR open [here](FormidableLabs/radium#930) react-addons-test-utils - moved to `react-dom/test-utils` react-icons - PR open [here](react-icons/react-icons#117) react-modal - No pending PR - likely a good idea to use a package that utilizes the React@16 portal functionality [this may work](https://www.npmjs.com/package/react-portal) react-simple-di - PR open [here](kadirahq/react-simple-di#13) react-test-renderer - This is part of React itself react-transition-group - Upgraded to 1.2.1 to support React@16 react-treebeard - 2.0.3 should accept React@16. not sure why we're getting a peer dependency error react-stubber - PR open [here](kadirahq/react-stubber#4) http://projects.theforeman.org/issues/21160
danseethaler
added a commit
to danseethaler/foreman
that referenced
this pull request
Oct 11, 2017
This PR is to prepare for and merge React@16.0.0 The current Foreman code is compliant with React@15.6.2 which means everything should work with React@16. I've looked through all the dependencies and made a list of necessary changes: react-komposer - PR open [here](arunoda/react-komposer#169) radium - PR open [here](FormidableLabs/radium#930) react-addons-test-utils - moved to `react-dom/test-utils` react-icons - PR open [here](react-icons/react-icons#117) react-modal - No pending PR - likely a good idea to use a package that utilizes the React@16 portal functionality [this may work](https://www.npmjs.com/package/react-portal) react-simple-di - PR open [here](kadirahq/react-simple-di#13) react-test-renderer - This is part of React itself react-transition-group - Upgraded to 1.2.1 to support React@16 react-treebeard - 2.0.3 should accept React@16. not sure why we're getting a peer dependency error react-stubber - PR open [here](kadirahq/react-stubber#4) http://projects.theforeman.org/issues/21160
danseethaler
added a commit
to danseethaler/foreman
that referenced
this pull request
Oct 12, 2017
This PR is to prepare for and merge React@16.0.0 The current Foreman code is compliant with React@15.6.2 which means everything should work with React@16. I've looked through all the dependencies and made a list of necessary changes: react-komposer - PR open [here](arunoda/react-komposer#169) radium - PR open [here](FormidableLabs/radium#930) react-addons-test-utils - moved to `react-dom/test-utils` react-icons - PR open [here](react-icons/react-icons#117) react-modal - No pending PR - likely a good idea to use a package that utilizes the React@16 portal functionality [this may work](https://www.npmjs.com/package/react-portal) react-simple-di - PR open [here](kadirahq/react-simple-di#13) react-test-renderer - This is part of React itself react-transition-group - Upgraded to 1.2.1 to support React@16 react-treebeard - 2.0.3 should accept React@16. not sure why we're getting a peer dependency error react-stubber - PR open [here](kadirahq/react-stubber#4) http://projects.theforeman.org/issues/21160
danseethaler
added a commit
to danseethaler/foreman
that referenced
this pull request
Oct 17, 2017
This PR is to prepare for and merge React@16.0.0 The current Foreman code is compliant with React@15.6.2 which means everything should work with React@16. I've looked through all the dependencies and made a list of necessary changes: react-komposer - PR open [here](arunoda/react-komposer#169) radium - PR open [here](FormidableLabs/radium#930) react-addons-test-utils - moved to `react-dom/test-utils` react-icons - PR open [here](react-icons/react-icons#117) react-modal - No pending PR - likely a good idea to use a package that utilizes the React@16 portal functionality [this may work](https://www.npmjs.com/package/react-portal) react-simple-di - PR open [here](kadirahq/react-simple-di#13) react-test-renderer - This is part of React itself react-transition-group - Upgraded to 1.2.1 to support React@16 react-treebeard - 2.0.3 should accept React@16. not sure why we're getting a peer dependency error react-stubber - PR open [here](kadirahq/react-stubber#4) http://projects.theforeman.org/issues/21160
|
Is there anything holding this back from being merged and released? |
This was referenced Oct 18, 2017
|
More importantly: is someone still maintaining this project? I see that the last commit on master was a long time ago. |
|
@arunoda would it be possible for you to merge this PR ? Thanks ! |
|
+1 |
|
We forked, fixed, and published this package as |
|
I use @storybook/mantra-core in a meteor v1.6.1 app, with react@16.2.0. But a have a problem with the composeWithTracker function. This function have been taken off react-komposer@2, used by storybook, but is still declared in @storybook/mantra-core/dist/index. So, I have a question. How could I send data from my containers to my components? Need help please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.