Sub network/schedule #103
Merged
Sub network/schedule #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gac55
approved these changes
Dec 8, 2021
| @@ -420,6 +420,10 @@ def links_on_spatial_condition(self, region_input, how='intersect'): | |||
| the tokens string copied using http://s2.sidewalklabs.com/regioncoverer/ | |||
| e.g. '89c25985,89c25987,89c2598c,89c25994,89c25999ffc,89c2599b,89c259ec,89c259f4,89c25a1c,89c25a24' | |||
| - shapely.geometry object, e.g. Polygon or a shapely.geometry.GeometryCollection of such objects | |||
| :param how: | |||
| - 'intersect' default, will return IDs of the Services whose at least one Stop intersects the | |||
There was a problem hiding this comment.
Great, I can see use cases for both types selection
| """ | ||
| logging.info('Subsetting a Network will likely result in a disconnected network graph. A cleaner will be ran ' | ||
| 'that will remove links to make the resulting Network strongly connected for modes: ' | ||
| 'car, walk, bike.') |
There was a problem hiding this comment.
Should this be parametrised for future compatibility? Perhaps not, as car, walk, bike is fairly standard and I can't think of any non PT modes we may introduce in the future. I suppose networks for scooters etc is technically possible.
| Subset a Network object using a spatial bound | ||
| :param region_input: | ||
| - path to a geojson file, can have multiple features | ||
| - string with comma separated hex tokens of Google's S2 geometry, a region can be covered with cells and |
There was a problem hiding this comment.
Lovely to see so many options. I imagine geojson will be v common, but S2 support is 🆒
* 5.2. Modifying Network - PT Schedule
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Methods to return a new
NetworkorScheduleobject subsetted using link IDs and service IDs.