Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen version constraints for various pytest-related dependencies #114

Merged
merged 3 commits into from
Apr 8, 2022

Conversation

mfitz
Copy link
Contributor

@mfitz mfitz commented Apr 8, 2022

When trying to install scop:
Screen Shot 2022-04-08 at 13 27 46

This is a spurious version clash - it is almost certain that both apps/libs will work with either version of pytest-cov.

We could decide to loosen the constraints for more than just these libraries, of course, but for now these will hopefully at least fix Scop's problem. Opinions welcome.

I may create a similar PR for MC that is much more flexible on the test dependencies, but still specific about non-test dependency.

@mfitz mfitz requested review from KasiaKoz and ana-kop April 8, 2022 12:33
requirements.txt Outdated
@@ -15,6 +15,7 @@ decorator==4.4.2
descartes==1.1.0
dictdiffer==0.8.1
docutils==0.15.2
Fiona==1.8.20
Copy link
Contributor Author

@mfitz mfitz Apr 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really likely to be something specific to my own machine, but I get fatal errors out of Fiona unless I pin to this specific version. I'm planning on getting a new machine soon, so hopefully this is just temporary, and I'm happy to remove this and keep the pinning as a local thing on my machine if anybody objects to it being here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have a vague memory that we deleted this from requirements as it was failing with windows users; geopandas handles fiona install, maybe if we're adding this, we should put it after geopandas on the list? (I think it installs top to bottom... it wont be alphabetical anymore though 😱 )

Copy link
Contributor Author

@mfitz mfitz Apr 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's tricky, and it only really helps me, I think maybe I will just remove it and manage that locally on my machine. I low key hate these libraries with native dependencies 😆

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@mfitz mfitz merged commit 1c3f423 into master Apr 8, 2022
@mfitz mfitz deleted the loosen_test_dependency_constraints branch April 8, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants